-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support scalar outputs from fusions #3947
base: polymorphic_outs_step_8
Are you sure you want to change the base?
Conversation
Review updated until commit 6f7b52e Description
Changes walkthrough 📝
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
…216_hidden_65536 in fusion_cache_utils.cpp.
group->producer_edges.push_back(new_edge); | ||
can_merge = codeGenSupportedMerge(new_group, group); | ||
new_group->consumer_edges.pop_back(); | ||
group->producer_edges.pop_back(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
new_group = nullptr; | ||
} | ||
} else { | ||
// TODO: handle the case where can_merge is false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Continue
@@ -3969,6 +4018,44 @@ SchedulerRuntimeInfo& SegmentCandidateFinder::runtimeInfo() { | |||
return *runtime_info_; | |||
} | |||
|
|||
SegmentGroup* SegmentCandidateFinder::initializeExprGroup(Expr* expr) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove, not helpful.
No description provided.